Discussion:
[e-lang] Patch for review: don't report errors twice
Thomas Leonard
2011-09-19 09:24:58 UTC
Permalink
Simple patch to fix E error reporting:

http://gitorious.org/~tal-itinnov/repo-roscidus/it-innovation/commit/c9a58031350e65d0b721f9b865dba821327703ba

Without the patch exceptions get reported twice:

$ cat test.e
foo
$ rune test.e
# problem: Failed: Undefined variable: foo
#
# @ </home/tal/tmp/test.e#:span::1:0::1:2>
# - EExpr#evalToPair(Scope)
# . e`foo`.evalToPair(<a Scope>)
# @ evalToPair/1:
<jar:file:/opt/src/e/dist/e.jar!/org/erights/e/elang/cmd/cmdMakerMaker.emaker#:span::128:57::128:66>

# problem: Failed: Undefined variable: foo
#
# @ </home/tal/tmp/test.e#:span::1:0::1:2>
# - EExpr#evalToPair(Scope)
# . e`foo`.evalToPair(<a Scope>)
# @ evalToPair/1:
<jar:file:/opt/src/e/dist/e.jar!/org/erights/e/elang/cmd/cmdMakerMaker.emaker#:span::128:57::128:66>
# - static Ref#fulfillment(Object)
# . <makeRef>.fulfillment(<ref broken by problem: Failed: Undefined
variable: foo>)
# @ fulfillment/1
--
Dr Thomas Leonard
IT Innovation Centre
Gamma House, Enterprise Road,
Southampton SO16 7NS, UK


tel: +44 23 8059 8866

mailto:***@it-innovation.soton.ac.uk
http://www.it-innovation.soton.ac.uk/
Kevin Reid
2011-09-19 11:05:02 UTC
Permalink
Post by Thomas Leonard
http://gitorious.org/~tal-itinnov/repo-roscidus/it-innovation/commit/c9a58031350e65d0b721f9b865dba821327703ba
Good to have this fixed; looks reasonable, but please explain the rationale in the source code as well as the commit message.
--
Kevin Reid <http://switchb.org/kpreid/>
Loading...